-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create README.md from Wiki content #342
Conversation
* The camera driver advertises a service call `<camera>/request_image` of type [polled_camera/GetPolledImage](http://www.ros.org/doc/api/polled_camera/html/srv/GetPolledImage.html). | ||
* The client calls the service, specifying an output namespace. | ||
* On receiving a request, the driver captures an image and returns its time stamp in the service response. | ||
* The driver publishes (latching) the [sensor_msgs/Image](http://www.ros.org/doc/api/sensor_msgs/html/msg/Image.html) and [sensor_msgs/CameraInfo](http://www.ros.org/doc/api/sensor_msgs/html/msg/CameraInfo.html) to `<response_namespace>/image_raw` and `<response_namespace>/camera_info`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here https://github.com/ros2/common_interfaces/blob/rolling/sensor_msgs/msg/Image.msg and https://github.com/ros2/common_interfaces/blob/rolling/sensor_msgs/msg/CameraInfo.msg
You might use this other one https://docs.ros2.org/foxy/api/sensor_msgs/msg/Image.html ? but rolling
is not working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we need to get better canonical links for messages.
* **Consistency:** Client-side processing is always performed in an image callback, regardless of what type of camera is used. | ||
* **Visibility:** Topics can be monitored in [image_view](https://index.ros.org/p/image_view/) or [rviz](https://index.ros.org/p/rviz/). | ||
* **Reproducibility:** Topics can be [bagged](https://index.ros.org/p/rosbag/) and played back later. | ||
* **Compression:** Can take advantage of [image_transport](https://index.ros.org/p/image_transport/) to compress images, if desired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to work to get the canonical link for packages to be the index page which is much better cross linked. It has a link directly to the API docs for each different version. We do need to get more README's ported. I'm doing this as a test of migrating content from the wiki . If we migrated to it's wiki page ( https://wiki.ros.org/image_transport) to it's README.md the link here would be much more useful. But as we're looking to wind down the wiki, we are considering a more bulk process and I'd like to do the linking with that in mind.
|
||
```bash | ||
# Poll "my_camera" at 5 Hz, publishing in namespace my_polled_output/. | ||
$ poller 5 camera:=my_camera output:=my_polled_output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this correct ?
ros2 run polled_camera poller 5 camera:=my_camera output:=my_polled_output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a clue, I'm just porting the documentation as it exists trying to apply some basic heuristics.
friendly ping @tfoote |
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Pulling from: https://wiki.ros.org/polled_camera#preview